Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning creates vehicles with invalid subcargos #2616

Closed
DorpsGek opened this issue Feb 7, 2009 · 1 comment
Closed

Cloning creates vehicles with invalid subcargos #2616

DorpsGek opened this issue Feb 7, 2009 · 1 comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 7, 2009

frosch opened the ticket and wrote:

The subtypes returned by callback 0x19 can change over time, as well as the number of available refits. See planeset for an example.

Cloning vehicles just copies the subtype, though it might not be available anymore.

Maybe a solution would be to test the available subtypes for the same D0XX text, and choose subcargo 0 if the old text number is not returned anymore.

(Autorenew and autoreplace could also profit from this, as they currently always choose subcargo 0. Esp. as some newgrfs change vehicle properties depending on subcargo. E.g. capacity in serbian tram set.)

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2616
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r18498


This comment was imported from FlySpray: https://bugs.openttd.org/task/2616

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant