Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

House property 15 not working #2613

Closed
DorpsGek opened this issue Feb 7, 2009 · 1 comment
Closed

House property 15 not working #2613

DorpsGek opened this issue Feb 7, 2009 · 1 comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 7, 2009

frosch opened the ticket and wrote:

  1. Setting property 0x15 does not deactivate the old house spec. Instead BuildTownHouse builds replaces the choosen houseid by the overriding houseid, if hs->override is defined. This causes the appearance probability of the old house to be added to the probability of the new house. Also it results in half houses, if the newgrf overrides houses by houses of different size (see attached testgrf by mb).

  2. Setting property 0x15 should replace old houses and replace them if they are present. (E.g. when changing newgrfs in game or SE)

So basically HouseOverrideManager should behave like IndustryOverrideManager, and GetHouseType like GetIndustryGfx (i.e. with ID translation).

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2613
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r18567


This comment was imported from FlySpray: https://bugs.openttd.org/task/2613

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant