Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EngineOverrideManager needed #2612

Closed
DorpsGek opened this issue Feb 7, 2009 · 3 comments
Closed

EngineOverrideManager needed #2612

DorpsGek opened this issue Feb 7, 2009 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 7, 2009

frosch opened the ticket and wrote:

Triggered when using "multiple newgrf engine sets" or when using a vehicle newgrf with more than the default number of engines per type.

During loading newgrfs the engine pool is populated with engines, i.e. a mapping from EngineID to GrfID+InternalID is created. It is recreated everytime and not stored in savegame.

When changing order of grfs, or when a "compatible" newgrf is loaded, that specifies a slightly different number of vehicles, the EngineIDs of all following newgrfs are shifted. Usually resulting in crashing.

So basically engines should behave like industries and houses, e.g. store the source of an EngineID and provide some minimal default properties when the definition is missing.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2612
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 8, 2009

frosch wrote:

as discussed with rubidium: likely feature 08 property 11 "GRF ID overrides for engines" also needs storing in savegame

This comment was imported from FlySpray: https://bugs.openttd.org/task/2612#comment5544

@DorpsGek
Copy link
Member Author

frosch wrote:

somewhat related: Is Action 4 still static-safe? If not, can it be made static-safe again?

This comment was imported from FlySpray: https://bugs.openttd.org/task/2612#comment5672

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2009

frosch closed the ticket.

Reason for closing: Fixed

in r15645. Some details may follow

This comment was imported from FlySpray: https://bugs.openttd.org/task/2612

@DorpsGek DorpsGek closed this as completed Mar 8, 2009
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek