OpenTTD

Tasklist

FS#26 - BIGMULS return-type fix

Attached to Project: OpenTTD
Opened by Graphite (Graphite) - Saturday, 10 December 2005, 21:44 GMT
Type Patch
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Very Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The current inline function for BIGMULS casts two numbers to 64-bit, then casts the result to 32-bit, only to then return a 64-bit value. This patch fixes that so it returns a 64-bit result without casting it to 32-bit.

Priority is very low since it currently causes no problems (it's only used in inflation calculations and those numbers stay small enough). However it is a bug worth fixing to avoid future problems if someone were to use BIGMULS with big numbers.
This task depends upon

Closed by  Darkvater (Darkvater)
Tuesday, 15 August 2006, 00:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  r5092

Loading...