Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGMULS return-type fix #26

Closed
DorpsGek opened this issue Dec 10, 2005 · 1 comment
Closed

BIGMULS return-type fix #26

DorpsGek opened this issue Dec 10, 2005 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Graphite opened the ticket and wrote:

The current inline function for BIGMULS casts two numbers to 64-bit, then casts the result to 32-bit, only to then return a 64-bit value. This patch fixes that so it returns a 64-bit result without casting it to 32-bit.

Priority is very low since it currently causes no problems (it's only used in inflation calculations and those numbers stay small enough). However it is a bug worth fixing to avoid future problems if someone were to use BIGMULS with big numbers.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/26
@DorpsGek
Copy link
Member Author

Darkvater closed the ticket.

Reason for closing: Fixed

r5092

This comment was imported from FlySpray: https://bugs.openttd.org/task/26

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
@andythenorth andythenorth mentioned this issue Jun 29, 2019
Closed
@LordAro LordAro mentioned this issue Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek