Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning when NewGRF does refit 'wrong' #2595

Closed
DorpsGek opened this issue Feb 1, 2009 · 4 comments
Closed

Show warning when NewGRF does refit 'wrong' #2595

DorpsGek opened this issue Feb 1, 2009 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 1, 2009

andythenorth opened the ticket and wrote:

Version: both r15297 and r15209

Problem: some articulated RVs 'forget' which cargo they are refitted for.

To reproduce: save game, quit OpenTTd, start OpenTTD, reload game.

Only certain vehicles are affected. The problem appears to be inconsistent even across different instances of the same type of vehicle (same ID) The problem may only be occurring with vehicles from the HEQS set, and may be related to cases where the lead vehicle has cargo capacity of 0. I am reasonably confident that my refit code for HEQS is sound.

Save game and HEQS grf attached. Other grfs are required for the savegame, but they are commonly used and available.

To find the problem it's a case of looking for vehicles that are stuck at a station waiting for a load which is not supplied, typically they should be fitted to iron and ore and are fitted to coal, or should be fitted to wood and are fitted to grain. The Rolling Thunder mining truck and Fastrac are the most commonly affected vehicles.

Happy to supply anything further required, or if it's my bad, I'll update the grf.

cheers,

Andy

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2595
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 1, 2009

andythenorth wrote:

BTW Mac OS version is 10.5.3

This comment was imported from FlySpray: https://bugs.openttd.org/task/2595#comment5503

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 1, 2009

frosch wrote:

Autorenew fails to refit the vehicle.

The problem is that the grf does not report that it is refittable in the purchase list. You added a custom text for that, but that is not the same :)
You also have to support the articulated-callback in the purchase list (action3 cargo id 0xFF)
Then it will show the capacity and the refittable cargo types in the purchase list, which is also used for autoreplace/autorenew which vehicles are refittable and can be replaced with each other.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2595#comment5504

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 1, 2009

frosch wrote:

About the OTTD side of this: There does not seems to be anything to prevent this, we can only check whether the purchase list refit-info is consistent with the refit-info the vehicle returns after building. And show an error message in that case.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2595#comment5505

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r15701. Sorry, you might get some reports :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2595

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Articulated labels Apr 6, 2018
@DorpsGek DorpsGek mentioned this issue Apr 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek