Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choosing water map edges via buttons instead of dropdown list #2566

Closed
DorpsGek opened this issue Jan 22, 2009 · 2 comments
Closed

Choosing water map edges via buttons instead of dropdown list #2566

DorpsGek opened this issue Jan 22, 2009 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

The choice of the map edges with water is easier to grasp, if you can choose the four map sides seperately with buttons. This patch removes the dropdown box and replaces it by four buttons. The size of the diff is large as it removes now unused strings in a number of language files in order to get rid of compile warnings.

Patch is for r15201.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2566
@DorpsGek
Copy link
Member Author

planetmaker wrote:

patch modified:
- with the coding style improvements as suggested by Yexo
- a randomize button which sets the border types randomly
- borders enum type is moved to landscape_type.h
- a big shuffling around the widgets to better present the orientation and fit into the window

A minor problem might be the string length for "NorthWest" and "SouthWest" for other languages than English; they are not right aligned...

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2566#comment5408

@DorpsGek
Copy link
Member Author

Yexo closed the ticket.

Reason for closing: Implemented

In 15212

This comment was imported from FlySpray: https://bugs.openttd.org/task/2566

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek