George wrote:

eGRVTS

Attachments

• dx2.png (5.41 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment5373

andythenorth wrote:

Can confirm that this is a right pain in the arse when coding ARVs. Have spent quite some hours trying different vehicle widths to try and address this, but the result is always a sub-standard compromise :(

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment6177

andythenorth wrote:

sorry annoying double post, browser-refresh screwup by me :(

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment6178

frosch wrote:

So, now I have a working patch for this :)

But some things are left:

1. Just to note: The default width for RV is 28, not 29 as for trains. Whatever TTDP guys intended with that... However due to compatibility I guess it is not acceptable to just default to 32 pixels.
2. So there is a need for some bit to activate it. This bit will be grf local (just as the train bit will be in near future). However, shall there be a separate bit (i.e. bit 6) for RV, or shall just the same bit (i.e. bit 3) be used as for trains?

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment6318

George wrote:

IMHO, there are no sets that have both RVs and trains, so if the bit is GRF based, then it can be the same bit.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment6319

frosch wrote:

Hmm, well. Attached is a patch and a win32 binary, which should work with the language files of nightly 16943.

It adds var 9E bit 6 to enable 32pixel view for roadvehicles (local per grf).
However, I am not that sure whether 32 pixels is the correct length here. RV are only shown horizontally/vertically in corners. and there two RV are never in a row (though maybe for shorter parts). So it is hard to tell, but 32 pixels seems a bit long to me. OTOH 32 is dividable by 8 which is useful for the n/8 length on straight road.

So maybe someone wants to test this, and figure out whether 32 pixels is suitable for various 1/8-8/8 vehicle lengths, or whether there is a better length :)

Attachments

• localvehiclelength_part6.diff (4.32 KiB)
• openttd16943roadveh32px.zip (1333.24 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment6383

frosch wrote:

Just for reference:
http://www.tt-forums.net/viewtopic.php?f=68&t=47057

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment7619

frosch closed the ticket.

Reason for closing: Implemented

in r24332

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553

frosch wrote:

The length of RV is now always 32 pixels independent of any flag.
A detailed analyses showed that 32 pixels is the correct length in inner and outer road corners: This can be seen for short articulated parts following each other in corners when they have both the horizonal orientation for a short time.

Since this also looks fine for most old GRFs, this has been made the default without any switch. (And those which do not look fine, also looked wrong before.)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2553#comment11280