Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow line height in create scenario window #2545

Closed
DorpsGek opened this issue Jan 16, 2009 · 5 comments
Closed

Snow line height in create scenario window #2545

DorpsGek opened this issue Jan 16, 2009 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Terkhen opened the ticket and wrote:

This simple patch adds an option in the create scenario window to change the snow line height. Without this patch, if you want a flat scenario with a certain snow line height, you have to enter into random land generation to change it, then come back to the original window.

Forum thread: http://www.tt-forums.net/viewtopic.php?f=33&t=41446

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2545
@DorpsGek
Copy link
Member Author

Terkhen wrote:

Sorry, here is the patch.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2545#comment5351

@DorpsGek
Copy link
Member Author

Terkhen wrote:

Changes in v0.2: Removed a few comments that have been added to trunk. Everything else keeps the same.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2545#comment5358

@DorpsGek
Copy link
Member Author

Belugas wrote:

I've been thinking a lot about that patch.
My opinion is not to put it in trunk as it is.
The main reason is more about the fact that it should be a subset of the generation world one, not a copy of some piece.
So... my preferred solution would be to make a base class for world generation, with the parameters required for it, without trees, industries and all, just the landscape itself.
Then, the current full-blown landscape generator will inherit from base class and expand it a bit.
What do you think?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2545#comment5365

@DorpsGek
Copy link
Member Author

Terkhen wrote:

If there are plans to separate both generation methods, then adding more duplicated code, like this patch, will only complicate it: the code for snow line selection, scenario size, max height, etc, should be only in the parent class. The heightmap generation could also get data from the same base class. It could even be possible then to define another methods of map generation that use different parameters if they're needed in the future. So I think your solution is way better.

What I don't really know is how to implement both gui in this OO model, because I'm still grasping the method used in OpenTTD to make guis. The most simple way would be to define some widgets in the parent class and then the rest of them in the child class, but I dont know if that's possible to begin with... Should we have a single enum to define the widgets in both windows and have the parent parent class use only a subset of them?.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2545#comment5369

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/2545

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant