Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave on time #2534

Closed
DorpsGek opened this issue Jan 13, 2009 · 6 comments
Closed

Leave on time #2534

DorpsGek opened this issue Jan 13, 2009 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Steve-N opened the ticket and wrote:

When using the loading order 'Load if available', vehicles can take a long time loading when new cargo is continuously arriving at the station. To enable vehicles to leave the station faster, this patch introduces two new loading orders:

Load available & leave
----------------------

This makes the vehicle leave as soon as all cargo that was available at the start of loading has loaded, even when the vehicle still has free space for cargo that enters the station during loading.

When gradual loading is enabled, this makes the vehicle leave as soon as all cargo that was available at the start of the last loading cycle has loaded. Cargo that entered that station during previous loading cycles will be loaded, only cargo that enters the station during the last loading cycle will be ignored.

When timetabling is enabled, this behaviour will be effected as soon as it is time to leave.

Note on different cargo types in trains:
When a train carries two or more available cargo types, and gradual loading is used, it is possible that it will stop loading a cargo type earlier than other cargo types, which could result in less of this cargo than would be possible to be loaded. Loading will stop per cargo type, as soon as there is less cargo available than can be loaded in a loading cycle.

Leave on time
-------------

This choice is only visible when both gradual loading and timetabling are enabled. Without gradual loading and timetabling, existing 'Leave on time' loading orders will behave the same as 'Load available & leave'.

This makes the vehicle leave as soon as it's time to leave according to the timetable. Unloading will always be completed first, followed by at least one loading cycle. When a vehicle is running late, it will leave right after the first loading cycle, possibly ignoring lots of cargo for which it has free space.

When no time is set for the current activity, this loading order behaves like 'Load available & leave'.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2534
@DorpsGek
Copy link
Member Author

Steve-N wrote:

r15075 patch

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2534#comment5329

@DorpsGek
Copy link
Member Author

PhilSophus wrote:

Two comments on the features themselves (I had no time to look at the code, yet):

  1. I don't consider the current trunk behavior very sensible as compared to your "load available & leave". That is, IMHO your behavior should replace the current one, instead of adding another option. People arriving later in the last loading cycle could be imagined as having arrived, when the doors of the vehicle have already closed and it is waiting for its clearance for departure.

  2. As for the "Leave on time": IMHO that defeats completely the gameplay aspect of timetables. If you don't give the vehicle enough time to unload and load the same should happen as when you don't give it enough time to travel: It should get late, and you should have to revise your timetable (i.e. exact the behavior we have in trunk, except for point 1 of course). Though, such a feature could make sense together with full load orders, if (and only if) there is no cargo to load (otherwise same as 1, load and depart then). That would give you a time-limited full-load order, something you don't have, yet.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2534#comment5346

@DorpsGek
Copy link
Member Author

Lurifax wrote:

Will this patch (or an improved version of it) be merged into trunk in the near future? Or will it be left as a patch which must be compiled by everyone who want to use it? Some functionality which forces a vehicle to leave precisely according to schedule (if possible) is much needed, as busy stations easily messes up the current timetabling system (I've seen trains running thousands of days late, even with no assigned travelling times).


This comment was imported from FlySpray: https://bugs.openttd.org/task/2534#comment6476

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 7, 2010

steven wrote:

Updated to r19051, changed to modify default behaviour instead of order-configurable.

This makes the vehicle leave as soon as all cargo that was available at the start of loading has loaded, even when the vehicle still has free space for cargo that enters the station during loading.

When gradual loading is enabled, this makes the vehicle leave as soon as all cargo that was available at the start of the last loading cycle has loaded. Cargo that entered that station during previous loading cycles will be loaded, only cargo that enters the station during the last loading cycle will be ignored.

When timetabling is enabled, this behaviour will be effected as soon as it is time to leave.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2534#comment7548

@DorpsGek
Copy link
Member Author

steven wrote:

http://vcs.openttd.org/svn/changeset/20506/ looks like a nice try to fix this issue, but doesn't really. It can fail on multiple-unit trains: It assumes all vehicles are full when only one is full. And if it would make the vehicle leave, it can leave early when timetables are being used.

Here's an updated leave_on_time patch for r20839.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2534#comment8822

@DorpsGek
Copy link
Member Author

michi_cc closed the ticket.

Reason for closing: Implemented

In r20843 with some changes.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2534

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant