Swallow opened the ticket and wrote:

Currently a VehicleOrderID is a byte, so it cannot be higher than 255. This limit, however, is not enforced anywhere. This leads to an overflow of OrderList->num_orders. An order count of exactly 255 could be even worse, as it marks the Orderlist as invalid.

The attached patch fixes this by adding a check in CmdInsertOrder, which limits the number of orders to 254 (INVALID_VEH_ORDER_ID - 1)

I can't see why anyone would ever add so many orders, but I think it's better to have this fixed.

Attachments

• max_vehicle_orders.patch (0.71 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2495