Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Savegame name includes "(undefined string)" as spectator [Patch] #2490

Closed
DorpsGek opened this issue Jan 3, 2009 · 2 comments
Closed

Savegame name includes "(undefined string)" as spectator [Patch] #2490

DorpsGek opened this issue Jan 3, 2009 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 3, 2009

Roujin opened the ticket and wrote:

When saving a game as spectator, the proposed save game name in the save/load window will always include the name of the first company. (see GenerateDefaultSaveName in saveload.cpp)

Now when there exists no company on a (dedicated) server, and you join as spectator and save the game, the proposed savegame name will be "(undefined string), {DATE}", as the first company does not exist.

Since it is rather hacky to just take the name of the first company, I propose to introduce a new string for this special case which says "Spectator" in the place where normally the company name is. The attached patch does this.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2490
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2009

Roujin wrote:

Well, since something was just committed to trunk that conflicts with my patch, here's an update for r14793. It also has some more comments now.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2490#comment5181

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2009

Rubidium closed the ticket.

Reason for closing: Fixed

In r14802

This comment was imported from FlySpray: https://bugs.openttd.org/task/2490

@DorpsGek DorpsGek closed this as completed Jan 3, 2009
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek