Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTTD in endless loop #2478

Closed
DorpsGek opened this issue Dec 25, 2008 · 5 comments
Closed

OpenTTD in endless loop #2478

DorpsGek opened this issue Dec 25, 2008 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

Run the savegame and wait the few days till 29 December. The game will start a loop, eating 100% of the core it runs on. Tested with r14736 and r14740.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2478
@DorpsGek
Copy link
Member Author

planetmaker wrote:

savegame file - wait till Dec 29.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2478#comment5147

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Train 3 is catching its own tail, PBS track following is in endless recursion.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2478#comment5148

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Simply checking whether we reach the begin tile solves the problem, but I fear that that won't work when reserving a path into a figure 9 (or 6) as the begin tile is not within the loop. So we need some kind of loop detection, but what's the upper bound for the length of a reserved path? I don't hope it's in the order of 2048x2048x2 (2 tracks per tile) as that's horribly expensive (CPU wise). A depth of 2048 doesn't adversely affect the behaviour, but there are cases of people building single stretches that long just to tell us that the signals don't work anymore.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2478#comment5167

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2009

michi_cc wrote:

This patch should solve the endless looping in all situations I can think of,
but I might have missed some special case. Some more testing wouldn't hurt.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2478#comment5199

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 5, 2009

michi_cc closed the ticket.

Reason for closing: Fixed

In r14849.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2478

@DorpsGek DorpsGek closed this as completed Jan 5, 2009
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant