Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to company rating calculations #2459

Closed
DorpsGek opened this issue Dec 19, 2008 · 4 comments
Closed

Minor change to company rating calculations #2459

DorpsGek opened this issue Dec 19, 2008 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Grantovich opened the ticket and wrote:

In competitive multiplayer games, the company ranking system is trivially exploitable: Just build a boatload of stations and vehicles that you never intend to use in some remote corner of the map, and you gain an easy 200 points.

Here are some simple changes to make "gaming the system" slightly more difficult. For the vehicle totals, only profitable vehicles are counted (v->profit_last_year > 0). And for the station totals, only recently-serviced stations are counted, using the same check that is applied to determine whether a station will influence a town's growth. I hope this is an appropriate amount of time, because I can't actually figure out what units are used by time_since_load and time_since_unload (no documentation?). To accompany these changes, I altered the PERFORMANCE_DETAIL tooltip strings to match the new logic, and to improve clarity.

This is the first patch I've ever submitted here, so let me know if I could be doing anything better. Thanks!

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2459
@DorpsGek
Copy link
Member Author

Grantovich wrote:

Oh, one more thing: I also changed the number of vehicles and stations required for full points to 100 and 50 respectively (down from 120 and 80). These are just based on my own observations of full-length games, so feel free to fine-tune them.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2459#comment5124

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 9, 2009

Grantovich wrote:

A friend advised me that separate changes should go in separate patches, so here's a modified patch with the change in the above comment removed. The patch now contains only the logic and string changes, leaving the rating requirements alone.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2459#comment5257

@DorpsGek
Copy link
Member Author

Grantovich wrote:

The old patch should still apply correctly, but here's an updated one just in case. Any devs seen this? I feel like I'm talking into a void here (though I know everyone is busy with 0.7).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2459#comment5606

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 9, 2009

Rubidium closed the ticket.

Reason for closing: Implemented

In r17485


This comment was imported from FlySpray: https://bugs.openttd.org/task/2459

@DorpsGek DorpsGek closed this as completed Sep 9, 2009
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant