Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong slope graphics under industry #2442

Closed
DorpsGek opened this issue Dec 7, 2008 · 11 comments
Closed

Wrong slope graphics under industry #2442

DorpsGek opened this issue Dec 7, 2008 · 11 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 7, 2008

George opened the ticket and wrote:

R14602

steep slopes are displayed incorrectly under industries near water

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2442
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 9, 2008

frosch wrote:

This is more like a feature request. And the downside is, that it would break other graphics:
See http://www.tt-forums.net/download.php?id=80066

So either there are only original shore graphics under industries, or only new.
In "slopes.png" it is even more critical, as the additional shore sprites are not available in industry sprite layouts.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5099

@DorpsGek
Copy link
Member Author

George wrote:

Yes, I understand the problem, but I do not know what to do. Could the code understand that a change is required because default land sprite is used? If yes, that would be a solution.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5104

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Now what if someone would make their industry create a pier which does not want the shore graphics on them? The major problem is that it's impossible to always correctly guess what the artist had in mind... and as frosch already said: you can't use the shore graphics in the sprite layout. They are not even part of standard NewGRF free OpenTTD, which makes the problem even bigger. Then there's also the issue of "flooding". We don't know whether the tile should be flooded or not, i.e. whether the default steep slope should be replaced with the flooded steep slope, and then there's no space to store the 'is flooded' information too.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5165

@DorpsGek
Copy link
Member Author

George wrote:

Rubidium, I understand, that this graphics is not accessible.
But I hope devs would suggest the best solution for coding. Grf authors would accept any solution here (new action 2, var cation2, something else, a callback maybe)
If you ask for my opinion about that, than I suppose a tile may have sum property (may be a bit in prop 12) to show, that it INTENDS the replacing. Would that be Ok?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5168

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2009

peter1138 wrote:

Perhaps some special value that means "use a default shore sprite"? We can easily specify that it will not behave like a normal shore tile, because... it's not one.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5224

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2009

George wrote:

Peter, you mean a bit in prop 12 to specify the behaviour? So, 0 would mean to use replacement, while 1 would mean use default graphics? That's fine :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5230

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2009

frosch wrote:

I still do not see a way, how OTTD could decide whether a tile is a shore tile or a grass tile. Especially due to autoslope and inner industry tiles, which are only surrounded by other industry tiles, i.e. not connected to water.

Maybe the land info of nearby tiles can be extended to distinguish sea from river/canal. Then the grf could check itself and one would only need a way to specify shore sprites in spritelayouts.

(Btw. when someone thinks about supporting shore sprites in spritelayouts, one could also think about foundations, resp. generally any action5 sprite. Though problem is, that they are not always available)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5232

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2009

George wrote:

Frosch:
I thought about some flag for industry tile, that would indicate it as water tile. This was needed to prevent rivers to draw river shore near such tiles. Possibly (?) it may lead to a problem with ships pathfinder?
From my point of view, the river idea is very inconvenient in general. Instead of changing water tile (drawing shores), I'd prefer to have the changed shore, the same way as seas do.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5235

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2009

frosch wrote:

River shore is suppressed if the industry tile was build on a water tile.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5237

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2009

George wrote:

Frosch:
Oh, ..... many bad words. Now, what tests should I do to understand, what graphics should the industry provide? Previously I tested water nearby, but now I also need to test the tile itself, because there can be both variants (with and without shore).
May I ask for a tile flag to force a tile become watered tile if nearby tiles are water (flooding under industry) to force removing river shore :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442#comment5238

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Implemented

Shore/river tiles can be detected in varact 2 checks since r20740 or so in 2010 :) https://git.openttd.org/?p=trunk.git;a=commit;h=c13035bbbb92e7ec57f0eb64c01db1beddbd7708

Might not be exact right commit - but this feature is now provided and newgrfs can provide appropriate sprites for tile.

Flyspray clean up - closing, thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2442

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs enhancement labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant