Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refit order doesn't work when using 'going to nearest depot' #2403

Closed
DorpsGek opened this issue Nov 11, 2008 · 8 comments
Closed

Refit order doesn't work when using 'going to nearest depot' #2403

DorpsGek opened this issue Nov 11, 2008 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

avd opened the ticket and wrote:

I've tried to use the order 'going to nearest depot' in combination with a refit order, but it doesn't work in r14572. I've tried to reproduce it too: if you use it with a specific depot it will work, but not if you use the nearest depot order...

Reported version: 0.6.3
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2403
@DorpsGek
Copy link
Member Author

avd wrote:

:/ forgot to change reported version into r14572


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403#comment5003

@DorpsGek
Copy link
Member Author

Antdovu wrote:

example of bug

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403#comment5004

@DorpsGek
Copy link
Member Author

Swallow wrote:

The attached patch file should fix the problem

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403#comment5005

@DorpsGek
Copy link
Member Author

SmatZ wrote:

The same applies to road vehicles, but the patch doesn't seem to fix it for them (though the code is shared). (I would like to hear I did the test wrongly, and this patch fixes the behaviour for RVs :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403#comment5007

@DorpsGek
Copy link
Member Author

Swallow wrote:

I ran a quick test with road vehicles and everything seemed to work as it should. Are you sure you tested correctly?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403#comment5008

@DorpsGek
Copy link
Member Author

frosch wrote:

yup, also works for me :)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403#comment5009

@DorpsGek
Copy link
Member Author

SmatZ wrote:

You made me happy, I tested it wrongly :-)
Attached is the testcase I used. The vehicles loses its "Going to nearest depot" status.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403#comment5010

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Fixed

In r14577. Thanks for nice report and help with fixing :-)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2403

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant