Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT_REACHED crash when building ECS Tourist Centre #2395

Closed
DorpsGek opened this issue Nov 2, 2008 · 8 comments
Closed

NOT_REACHED crash when building ECS Tourist Centre #2395

DorpsGek opened this issue Nov 2, 2008 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Nov 2, 2008

Aali opened the ticket and wrote:

Savegame for r14558 with instructions on how to reproduce it attached.

The exact error is: NOT_REACHED triggered at line 159 of ..\src\strings.cpp

Requires ECS Town Vector beta 5 newgrf

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2395
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 2, 2008

George wrote:

may be it is the same error.

Looks Like I got the similar bug for industry construction
308 * 21 04 0A FF 01 E5 DC "ÞCement works" 00
309 * 21 04 0A 82 01 E5 DC "ÞZementfabrik" 00
310 * 24 04 0A 83 01 E5 DC "ÞUsine de béton" 00
311 * 18 04 0A 84 01 E5 DC "ÞCementera" 00
312 * 38 04 0A 87 01 E5 DC "ÞЦементный завод" 00
313 * 28 04 0A A7 01 E5 DC "ÞFabbrica di cemento" 00
OTTD crashes with the following Error text: String 0xDCE5 is invalid. Probably because an old version of the .lng file.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395#comment4984

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 2, 2008

George wrote:

In TTDP it reports string undefined, but do not crash

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395#comment4985

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 2, 2008

George wrote:

The problem happens only in red construction fail window. The same e5 dc works fine as industry name.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395#comment4986

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 3, 2008

George wrote:

Forgot crash logs. Here they are

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395#comment4987

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 3, 2008

George wrote:

I checked both D0 and DC strings, effect is the same

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395#comment4988

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 3, 2008

George wrote:

putting default strings like 48xx instead Dxxx string removes the crash. Very strange.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395#comment4989

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 3, 2008

George wrote:

I found a way to fix this bug on a GRF side
DCxx string should be changed to D0xx string, represented as D4xx.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395#comment4990

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 4, 2008

Rubidium closed the ticket.

Reason for closing: Fixed

In r14563.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2395

@DorpsGek DorpsGek closed this as completed Nov 4, 2008
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek