Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved breakdowns #2302

Closed
DorpsGek opened this issue Sep 15, 2008 · 16 comments
Closed

Improved breakdowns #2302

DorpsGek opened this issue Sep 15, 2008 · 16 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Swallow opened the ticket and wrote:

This patch improves breakdowns. It features different types and severities of breakdowns, multiengine support and load-dependant breakdown chance. Currently it is train-only. For more information see the forum post: http://www.tt-forums.net/viewtopic.php?f=33&t=39518

Patch is against r 14286

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2302
@DorpsGek
Copy link
Member Author

yorick wrote:

I notice a problem when you have, for example, 10 engines, the train breaks down 10 times as much, and every broken down engine is reported as if the whole train is broken. Also the emergency stops and mechanical failures happen 10 times as much.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4749

@DorpsGek
Copy link
Member Author

Swallow wrote:

Attached is the newest version of this patch

@yorick
You have a valid point here I think. Originally my intention was that the breakdowns which affect multiengine trains less (low power) would balance the increase in emergency stops and mechanical failures. I have done some quick testing, and it seems trains with many engines are indeed stopping too much because of breakdowns. I think I will therefore change the behaviour of emergency stops, so they happen only to the front engine. This should alleviate the problem somewhat. I'm not sure though, as I need to do some more playtesting first.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4800

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 1, 2008

Swallow wrote:

The attached diff disables emergency stops for all train engines except the first one. This should significantly reduce the problem of multiengine trains stopping too often. It also fixes a bug; the reliability of non-front engines now properly decreases when improved breakdowns is off.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4805

@DorpsGek
Copy link
Member Author

Swallow wrote:

Let's keep this up to date a bit...

Attached is version 2.3

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4870

@DorpsGek
Copy link
Member Author

Swallow wrote:

Fix some minor issues regarding disasters


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4908

@DorpsGek
Copy link
Member Author

yorick wrote:

where?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4909

@DorpsGek
Copy link
Member Author

Swallow wrote:

Damn, forgot to attach the file. This is beginning to look like an awfully long list of replies-to-self ;-)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4910

@DorpsGek
Copy link
Member Author

sbr wrote:

Hi,

Attached is an updated version of this patch. Based in r14542 it includes some minor fixes:
- hack languages files: append " - {STRING1}" to STR_885C_BROKEN_DOWN. Clean fix should add a new entry for all type of broken states.
- add a 'default:' clause to the switch in the initialisation routine in AfterLoadGame().
- add a cast to uint64 when performing v->breakdown_chance in train_cmd.cpp.
- in vehicle.cpp a reduced breakdown chance is defined for multiheaded trains but isn't used. Use it to check vehicle breakdown.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4965

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 4, 2008

Swallow wrote:

Thanks for your update, especially the fix in vehicle.cpp which really affected functionality.
I implemented your changes and some other fixes in version 2.4, although I kept the language files in a separate patch, see the forum thread.
File:

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment4993

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 5, 2009

sbr wrote:

Updated patch to r15954. The only change made come from r15308 regarding km-ish/h -> mph conversions for 'low speed' breakdowns.
Fixed languages files are in the second patch.

EDIT: there is a typo in the patches names: s/19504/15954/

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment5899

@DorpsGek
Copy link
Member Author

Bigos82 wrote:

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment6754

@DorpsGek
Copy link
Member Author

Bigos82 wrote:

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment6856

@DorpsGek
Copy link
Member Author

Bigos82 wrote:

Last 2 files had some errors... Now its should be ok.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment6879

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 1, 2012

mag103 wrote:

This patch must be in the trunk in the future


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment11058

@DorpsGek
Copy link
Member Author

Milsa wrote:

Please add this patch to trunk.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302#comment12570

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: more than 5 years old, and not obvious what should be done with this next, so closing. If this offends, discuss with andythenorth in irc. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2302

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant