Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSK does not get repainted when opened from network message window #2296

Closed
DorpsGek opened this issue Sep 13, 2008 · 2 comments
Closed

OSK does not get repainted when opened from network message window #2296

DorpsGek opened this issue Sep 13, 2008 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Zuu opened the ticket and wrote:

In a network game:

* Open the network message window (chat box)
* Click in the chat edit box to open the on screen keyboard (OSK) window
* Type a message with your keyboard

Now you should see that the edit box of the OSK window does not get repainted very often as if you opened the OSK window for example the query string window.

I've tried to track this down, but what I've found is that OnPaint() for the OSK window is not called so, it does not get repainted, but I have not yet found out what triggers the OSK-window being marked dirty in the cases when the OSK window repainting works.

If I've understood correctly the network message window is always placed in the bottom of the _z_windows array as a special case, but I've not been able to relate that to this problem.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2296
@DorpsGek
Copy link
Member Author

Zuu wrote:

It seams like the problem lays in that the variable b never (or very very seldom) become true for the OSK-window when it is opened by the network message window:

bool HandleCaret(Textbuf tb)
{
/ caret changed? */
bool b = !!(_caret_timer & 0x20);

if (b != tb->caret) {
tb->caret = b;
return true;
}
return false;
}

This comment was imported from FlySpray: https://bugs.openttd.org/task/2296#comment4741

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r14318.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2296

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek