Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localized Thousand Separator #2287

Closed
DorpsGek opened this issue Sep 10, 2008 · 3 comments
Closed

Localized Thousand Separator #2287

DorpsGek opened this issue Sep 10, 2008 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Eddi opened the ticket and wrote:

{COMMA} Numbers in strings have a hardcoded separator ','

this patch adds a pragma "separator" to language files, so they can specify their own thousand separator (for non-currency numbers)

it defaults to ',' when the pragma is not specified

as an example, it adds
"# # separator ." to german.txt

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2287
@DorpsGek
Copy link
Member Author

Eddi wrote:

i've made a "multi-character" version, and it works for several characters (..) and utf-8 characters (ä), although neither appear like they make any immediate sense to me ;)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2287#comment4727

@DorpsGek
Copy link
Member Author

Rubidium wrote:

The separator shouldn't be a hardcoded constant from the language, but rather a per client setting like the currency; it might very well be that one wants to use English but a "." as separator or German with a "," as separator.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2287#comment4949

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

in another way though

This comment was imported from FlySpray: https://bugs.openttd.org/task/2287

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek