Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume value bug - r14286 #2286

Closed
DorpsGek opened this issue Sep 10, 2008 · 1 comment
Closed

Volume value bug - r14286 #2286

DorpsGek opened this issue Sep 10, 2008 · 1 comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

kakaopor opened the ticket and wrote:

In settings.cpp on line 1133 and 1134 the music_vol, effect_vol is declared to 128 by default, but with a 0..100 range. So when loading from config, it may truncate to 100.

In fact the volume bars in the music player can never reach 128 (the default value), because of a min(max(..., 0), 127) in music_gui.cpp on line 489.

I've attached the patch for these.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2286
@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Fixed

In r14289 in a bit different way, thanks for the patch!


This comment was imported from FlySpray: https://bugs.openttd.org/task/2286

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant