Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot load very recent save games #2272

Closed
DorpsGek opened this issue Sep 4, 2008 · 6 comments
Closed

Cannot load very recent save games #2272

DorpsGek opened this issue Sep 4, 2008 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 4, 2008

eekee opened the ticket and wrote:

Some save files saved today from r14239 fail to load. Loading was attempted with the same build of r14239, and with r14245 built on the exact same system. Nothing about the system has changed. OTTD exits with the following error:

openttd: /home/ethan/o/ottd/14245/src/train_cmd.cpp:272: void TrainConsistChanged(Vehicle*, bool): Assertion `u->First() == v' failed.

Attached are (in order):
* The last save which loads successfully
* The first save which fails
* The last save which fails

All these are from the one game. I cannot reproduce this by saving other games, but these failing save games fail consistently.

I'm not sure if this is version-related or not. It's possible that the last successful save was saved from r14234, but it was more likely saved from r14239.

Attachments

Reported version: trunk
Operating system: Linux

This issue was imported from FlySpray: https://bugs.openttd.org/task/2272
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 5, 2008

Rubidium wrote:

Did you recently do any vehicle replacements (esp. trains)?
As some trains seem to have multiple fronts.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2272#comment4688

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 5, 2008

eekee wrote:

I converted it from original trains to UKRS 7 game years before the first failure. I scrapped all the original trains & built entirely new ones, so there should be no replacement from age. The only things I recall doing since are some track-work and cloning a few trains (ctrl-click). In particular the T. Valley to T. Forest line had 2 or 3 more trains, all clones of the others on that line.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2272#comment4694

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2008

SmatZ wrote:

There are invalid disaster vehicles even in that supposed working savegame. Do you have any older savegame? (as old as possible)
Disasters are Off in your savegame, have you ever played with them?
You have changed GRFs many times, I wouldn't wonder if that was the reason...

This comment was imported from FlySpray: https://bugs.openttd.org/task/2272#comment4709

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2008

SmatZ wrote:

You may use attached diff to fix your savegame. I can't do that because I miss your GRFs.

The problem was probably caused in a (very) old OTTD revision, the bug has been most likely fixed already.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2272#comment4710

@DorpsGek
Copy link
Member Author

eekee wrote:

The invalid disaster vehicles have been there a long time. I was thinking of asking for help just to remove the shadows before this trouble happened. They were produced by an old version, perhaps r10201-r10318 or perhaps before. Many UFOs have crashed in newer versions without leaving shadows, so yes, it's an old bug that has been fixed.

The patch worked, thank you!

This comment was imported from FlySpray: https://bugs.openttd.org/task/2272#comment4726

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Fixed

Caused by invalid disaster vehicles, this bug isn't reproducible in trunk. Most likely fixed long time ago.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2272

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek