Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewGRF GUI improvement #2195

Closed
DorpsGek opened this issue Aug 6, 2008 · 10 comments
Closed

NewGRF GUI improvement #2195

DorpsGek opened this issue Aug 6, 2008 · 10 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 6, 2008

Tiberius opened the ticket and wrote:

This is a improved version of NewGRF GUI window, using 2-column layout.
It supports window resizing, and drag-drop reordering of loaded NewGRF files.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2195
@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 2, 2008

planetmaker wrote:

update to r14423. Question: is the info part for the individual grf still sufficiently large?

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment4808

@DorpsGek
Copy link
Member Author

planetmaker wrote:

fixed a small one-off error in the widget sizes, avoiding pixel trails when moving the window to the left. Otherwise unchanged.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment5076

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 8, 2009

Timitry wrote:

What a great improvement! The NewGRF-Window is so uncomfortable, especially if you want to add a lot of NewGRFs!
Please keep up the good work with it :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment5244

@DorpsGek
Copy link
Member Author

planetmaker wrote:

update to r15084 and a slight change in the button layout which is now a tiny bit more like the existing NewGRF UI

Questions to the devs: is it desirable to have an advanced setting to toggle between use of this new gui and the existing?

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment5340

@DorpsGek
Copy link
Member Author

planetmaker wrote:

update to trunk r15211
Change: integration of the "check online content" button which hit trunk in the meantime.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment5411

@DorpsGek
Copy link
Member Author

planetmaker wrote:

update to current trunk and fix of a few resizing issues and mixing up of two buttons.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment5426

@DorpsGek
Copy link
Member Author

planetmaker wrote:

Sorry for the spam. I played around with this widget arrangements, especially testing a small size of this window, taking the game main menu as a reference for that. I think I could improve the layout quite a bit. See the attached screenshots for an impression how it looks like.

The two diff files are for r15256 and differ as follows:
v1 is the layout with two seperate file infos (newgrf_gui_320.png)
v2 is the layout with a unified file info (newgrf_gui_v2_320l.png, newgrf_gui_v2_normal.png)

newgrf_gui_v2_normal is the usual, un-resized window

I think the new (v2) layout has also in normal mode an advantage over the design as it was before: longer descriptions are now nearly always completely displayed due to the longer line length available for the text strings.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment5432

@DorpsGek
Copy link
Member Author

batti5 wrote:

Ok, but this should be syncronised with BaNaNas.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment5603

@DorpsGek
Copy link
Member Author

Alberth wrote:

In r19829-r19845 the NewGRF gui got changed, much inspired by the proposals in this issue. Thanks go to planetmaker for his efforts.
What remains to be done here is checking whether the patch attached here has useful extras that can be ported to trunk.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195#comment8065

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented


This comment was imported from FlySpray: https://bugs.openttd.org/task/2195

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant