Roujin wrote:

After glx's suggestion to save the currently selected server's position instead of searching through the list every time, here's a second version.

It also features scrolling to the selected server when clicking on the "last visited server" panel.

Please comment.

Attachments

• network_window_scroll_2.diff (3.81 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2194#comment4541

Roujin wrote:

Fixed two small style mistakes.

Attachments

• network_window_scroll_2_fixed.diff (3.81 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2194#comment4546

Roujin wrote:

Update to r14505, now also includes pageup, pagedown, home and end keys - they do what is obvious. Also fixed the issue that 0 is a valid position in the list, and switched to uint16, which the number of servers should never reach.

Please comment (pretty please?)...

Attachments

• network_window_scroll_3_r14505.diff (5.96 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2194#comment4911

Rubidium wrote:

+typedef uint16 ServerListPosition;
+enum {SLP_INVALID = 0xFFFF};
You can better use static const ServerListPosition SLP_INVALID = 0xFFFF; here so you don't have to cast in "? : " statements with SLP_INVALID.

Furthermore this->list_position can be -1 or 0 in OnKeyPress which might cause segmentation faults. So I think you should ignore keypresses when there are no servers in the list.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2194#comment4920

Roujin wrote:

Thanks for your feedback! I will implement the two suggestions as soon as I can and reupload it here then.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2194#comment4925

Roujin wrote:

Here's the new version with the two changes.

Attachments

• network_window_scroll_4_r14509.diff (6.03 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2194#comment4927

Rubidium closed the ticket.

Reason for closing: Implemented

In r14517.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2194