Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immediate unload of transferred cargo when waiting for full load #218

Closed
DorpsGek opened this issue Jun 24, 2006 · 3 comments
Closed

Immediate unload of transferred cargo when waiting for full load #218

DorpsGek opened this issue Jun 24, 2006 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

TubularBell opened the ticket and wrote:

Note: See attached savefile for graphical explanation of the problem. Un-stop the bus and unpause. Enjoy the show.

There is a problem using the Transfer system. When a feeder-line unload+tranfers its cargo on a station that has the main line waiting for full load, the main line picks up the cargo (which sets it's cargo_source to the station the feeder came from!). The next tick the game sees this cargo in the main line, checks the cargo_source and realizes it does not match the current station and therefor unloads. Result: immediate unload of transferred cargo.

My patch adds a check to the unload routine to check if the current order is Full Load. If it is, the unload will not happen - why would you want a vehicle that's loading up to be unloaded?

Note: This is my first time writing C++ for the public and my first time messing in OpenTTD. If I made mistakes, I'd be happy to hear them.

Attachments

Reported version: 0.4.7
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/218
@DorpsGek
Copy link
Member Author

TubularBell wrote:

Doh. You can shoot me now. The patch does fix the problem beautifully. However, it also stops vehicles from unloading at all. That's what I get for doing something I know nothing about. Back the sketchboard.

This comment was imported from FlySpray: https://bugs.openttd.org/task/218#comment331

@DorpsGek
Copy link
Member Author

PandaMojo wrote:

Seems to be a fix/duplicate of #177. Added a patch which seems to work there. Took me the better part of half a day to figure out, and thought I'd solved it 3 times without other sideffects at least. Hopefully the current one truely is :-).

This comment was imported from FlySpray: https://bugs.openttd.org/task/218#comment423

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 2, 2006

Darkvater closed the ticket.

Reason for closing: Duplicate

251, please continue there

This comment was imported from FlySpray: https://bugs.openttd.org/task/218

@DorpsGek DorpsGek closed this as completed Nov 2, 2006
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
@DorpsGek DorpsGek mentioned this issue Apr 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek