Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cargo ID lookup with GRFv7 #2157

Closed
DorpsGek opened this issue Jul 22, 2008 · 1 comment
Closed

Invalid cargo ID lookup with GRFv7 #2157

DorpsGek opened this issue Jul 22, 2008 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

minime opened the ticket and wrote:

Present in all relevant revisions, up to present time.
From http://wiki.ttdpatch.net/tiki-index.php?page=Action0Industries# Acceptance_cargo_types_11_

"If your GRF has a cargo translation table, then this ID is the index in that table; otherwise, it's the cargo bit."
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Currently OTTD doesn't honour this last sentence (present code assumes all GRFv7 files contain a cargo translation table - that's an incorrect assumption, as there is nothing mandating it's presence.). Attached patch fixes this issue, attached GRF demonstrates it (the industry should produce cargo 07).

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2157
@DorpsGek
Copy link
Member Author

peter1138 closed the ticket.

Reason for closing: Fixed

Fixed in r13855


This comment was imported from FlySpray: https://bugs.openttd.org/task/2157

@DorpsGek DorpsGek added NewIndustries flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant