Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved autoclean_* #2151

Closed
DorpsGek opened this issue Jul 20, 2008 · 5 comments
Closed

improved autoclean_* #2151

DorpsGek opened this issue Jul 20, 2008 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

thomasdev opened the ticket and wrote:

just a really short patch to be able to disabled that protected companies get removed at all. (but unprotected will still be removed)

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2151
@DorpsGek
Copy link
Member Author

Rubidium wrote:

I see absolutely no functional change in this patch; the allowed range of the variables will cause the newly added comparisons to be always true.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2151#comment4478

@DorpsGek
Copy link
Member Author

thomasdev wrote:

as you might have noticed i change the range from uint8 to int in order to allow negative numbers.

this allows you to configure:
autoclean_companies = true
autoclean_protected = -1
autoclean_unprotected = 2

which will only remove unprotected companies.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2151#comment4480

@DorpsGek
Copy link
Member Author

Rubidium wrote:

It's just that loading clamps the value between 0 and 60 (protected) or 0 and 180 (unprotected).

This comment was imported from FlySpray: https://bugs.openttd.org/task/2151#comment4481

@DorpsGek
Copy link
Member Author

thomasdev wrote:

oh, indeed, forgot to change that as well, fixed with attached patch (changed 0 to -1)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2151#comment4483

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

though differently in #13773; 0 means do not autoclean.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2151

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek