Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some passenger artic. road vehicles can only be sent to truck stops. #2105

Closed
DorpsGek opened this issue Jun 23, 2008 · 5 comments
Closed

Some passenger artic. road vehicles can only be sent to truck stops. #2105

DorpsGek opened this issue Jun 23, 2008 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Zephyris opened the ticket and wrote:

(nightly-r13592) Articulated road vehicles which have a front vehicle capacity of zero and a cargo type of passengers can only be given orders to truck stops and not bus stops. A test GRF with such vehicles may be found here: http://www.tt-forums.net/viewtopic.php?p=701956# p701956

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2105
@DorpsGek
Copy link
Member Author

Rubidium wrote:

The problem is that the cargo of the first vehicle is not something that is a like passenger (includes tourists). Because of that it will not go to a bus stop.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2105#comment4374

@DorpsGek
Copy link
Member Author

Zephyris wrote:

I thought that would be the case, maybe it should be altered to check the total capacity, not just the front vehicle...


This comment was imported from FlySpray: https://bugs.openttd.org/task/2105#comment4375

@DorpsGek
Copy link
Member Author

Rubidium wrote:

I've fiddled a little with the code to 'ignore' the CargoID of 0 capacity vehicles in an articulated rv. However... it changes the CargoID of vehicles with capacity 0 to the CargoID of the first vehicle with capacity != 0.

I fear that this causes unexpected things to happen for NewGRF writers, especially with callbacks and such. However, searching for the cargo type in each vehicle when checking to which station a vehicle has to go in the pathfinder doesn't appeal to me at all as it would slow down the game for something that we could easily prevent.

The attached hack 'works' for the passenger horse carriages, but again I think it is not the right thing to do. I'm wondering how hard it would be for a NewGRF writer to set the cargo type to that of the cargo that will be carried.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2105#comment4376

@DorpsGek
Copy link
Member Author

Zephyris wrote:

This does seem a "hacky" solution - and in this case the GRF can easily be changed. Though I think there needs to be some documentation for coding articulated vehicles to clear up confusion about things like this, I'll start to put together some...


This comment was imported from FlySpray: https://bugs.openttd.org/task/2105#comment4377

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

the wiki ;)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2105

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Articulated labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant