Rubidium wrote:

This implementation causes desyncs:
Client A has normal rail selected and builds a station.
Client B has maglev selected. Building the station fails on this computer.

Furthermore the behaviour can't be the same as in TTDP because TTDP doesn't have a type '3'. Furthermore monorail is always mapped to # 2 in OTTD, whereas in TTDP it depends on whether there is elrail.

So effectively there needs to be some variable that is set on any station callback and reset after that callback in order to make it MP safe.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2091#comment4331

mart3p wrote:

[Desyncs] Yes, I didn't consider multiplayer, I should have known it wouldn't be that simple.

[Rail type '3'] My assumption here was that TTDPatch would return '0' for normal rail, '1' for electrified, '2' for monorail and '3' for maglev, regardless of the elrail setting, the same as var 42 (it's not actually documented for var 11). Having now tested this further in TTDPatch, it seems my assumption was wrong.

Not an easy one to implement then...

This comment was imported from FlySpray: https://bugs.openttd.org/task/2091#comment4338

Rubidium wrote:

The attached version is MP safe... however:
- it only works for the station availability callback
- it thus doesn't work for the station drawing in the station picker
- it doesn't recheck availability when converting the rail, so you can still build any station for any railtype

Even then, the result would be quite unusable in most cases; 3 return values and 4 rail types is really messy.

So still a large amount of work to do for not much of a benefit. And when we get railtypes it becomes even more messy.

Attachments

• fs2091.diff (6.11 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2091#comment6242

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

(Also, railtypes - added complexity)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2091