Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tile's snowing #2071

Closed
DorpsGek opened this issue Jun 12, 2008 · 13 comments
Closed

Improve tile's snowing #2071

DorpsGek opened this issue Jun 12, 2008 · 13 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

Currently a tile is snowed according to the high of its' lowest corner. That makes a road on slopes look very ugly - the road is flat, but some parts are snowed (flat land tiles) and some are not (tiles on slopes). It would be nicer, if the snowing of tile would be defined according to its' highest corner.

Reported version: 0.6.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2071
@DorpsGek
Copy link
Member Author

SmatZ wrote:

Is the way how railroad works with snow fine? (eg. is this what you mean?)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4260

@DorpsGek
Copy link
Member Author

George wrote:

Yes


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4266

@DorpsGek
Copy link
Member Author

George wrote:

After some thinking...

Yes, but I want more. I want it to be applied to houses and industry tiles too.
So, the behaviour of railways is not absolutely correct. When I have a flat railway on slope it is snowed, but if it goes 1 level below, the sloped rail tile is not snowed. In my suggestion I suggest to have it snowed too.
/-------------
----/ ^
^ ^^|- this is snowed and should be.
| |- this part is not, but should be = the main idea of the change.
---- this part is not snowed.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4269

@DorpsGek
Copy link
Member Author

George wrote:

I want this tile to be snowed

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4271

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Wouldn't this be better?

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4272

@DorpsGek
Copy link
Member Author

George wrote:

It is better, but it does not solve the problem in general. I was thinking about houses and industry tiles too.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4274

@DorpsGek
Copy link
Member Author

frosch wrote:

You can read the snow line height from variable 20, and you can read the house tile height from variable 62 (houses) resp. 60 (industries).
So you are free to customize.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4275

@DorpsGek
Copy link
Member Author

George wrote:

Yes, I can, but from my point of view the right way to check the snow is to read var 62 only
Like this
585 * 15 02 07 14 81 62 00 0A 0F 01 12 00 04 04 11 00
and because I can test one var, why should I test two? The better way is to have the right value in the var. Especially because this change should not affect existing GRFs (IMHO).


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4277

@DorpsGek
Copy link
Member Author

SmatZ wrote:

I agree tile height should be changed.
It is not fine that when you use autoslope, an industry tile may get under snow line.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4278

@DorpsGek
Copy link
Member Author

frosch wrote:

Ok, I thought you would follow SmatZ' example, and supply houses/industries with different graphics for different snow amounts :) (like first the garden, then the road, then the roofs).

About changing the current behaviour: IIRC the Alpine newgrf only allows farms below the snowline. When changing the offset they might get above it. Though changing the reference height from minimal tileheight to maximal tileheight should not be a problem. (esp. because of autoslope)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4279

@DorpsGek
Copy link
Member Author

frosch wrote:

Hmm, on the other hand one leave industries/houses as they are, and modify the clear tiles instead. (i.e. fully snowed starts one level above snowline)
Though the minimal->maximal change still holds.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4280

@DorpsGek
Copy link
Member Author

George wrote:

IMHO, one level objects are not affected. My request was only aimed to sloped tiles. I do not suggest to change snow line. I suggest to change the way to determinate the snowed/not snowed state for sloped tiles.

As for several snowed levels. The way I code my industries and houses is planned to support this feature and can be relative easy added.
But I have a question - how to check snow state of the tile. I do not like the idea to test the difference between the tile height and snow line height. I want to test the state only (the way I do now), so only the var like var 60 or 62


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071#comment4281

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: much more than 5 years old, and not obvious what should be done with this next, so closing. If this offends, discuss with andythenorth in irc. Thanks.

Chain varaction 2 / nml switches to compare snowline and tile height. Doesn't need a specific var. Possibly a built-in nml expression could be provided (https://newgrf-specs.tt-wiki.net/wiki/NML:Builtin_functions). I think that's TMWFTLB though.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2071

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant