glx wrote:

This doesn't happen for me.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2004#comment4122

Rindvieh wrote:

I've tested it with 32bit and 64bit both the same result.

I use Visual Studio and not Visual C++ Express (for 64bit), compile under Vista and use TortoiseSVN. During compilation he "Determining version number" and in rev.cpp is the correct rev number. So I would say it's nothing with TortoiseSVN. Maybe something with Studio but I don't know.

Cheers,
Rindvieh

This comment was imported from FlySpray: https://bugs.openttd.org/task/2004#comment4123

michi_cc wrote:

Confirmed at least for VS9 Professional. The file rev.cpp is correctly updated, but the build process does not pick it up as modified.
The next build cycle (i.e. pressing F7 again) will recompile that file and have the right in-game revision.

It looks like the modified files are gathered before running the custom pre-build event. As it's not possible to specifiy output files
for a pre-build event, rev.cpp will only be picked up by subsequent builds.

A Custom Build Step can define output files, but I don't see a suitable file to define such a step. A custom build step for the project
file itself is not working as it will be executed after linking.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2004#comment4128

Rubidium wrote:

What about a project where the main project depends on to perform the version determination?

This comment was imported from FlySpray: https://bugs.openttd.org/task/2004#comment4347

michi_cc wrote:

The attached patch changes the revision detection to use a dependant project to do its task.
It seems to work at least on my local machine.

Note that the VS2005 part is completely untested as I don't have access to that version.
But the project file format is not very different so I have hope that it might work.

Attachments

• 0001--Codechange-MSVC-version-detection-now-uses-a-separ.patch (11.52 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2004#comment4535

Rubidium closed the ticket.

Reason for closing: Fixed

In r13998. Thanks michi_cc!

This comment was imported from FlySpray: https://bugs.openttd.org/task/2004