Roujin wrote:

Due to the changes in trunk regarding viewport/window stuff, here's an update to the new way of handling stuff in viewport.cpp.

Also threw out some unneeded stuff and applied some coding style.

Attachments

• drag_draw_scedit_v2_r13031.diff (12.18 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4115

Roujin wrote:

Updated. No changes done. Please comment? :/

Attachments

• drag_draw_scedit_v2_r13059.diff (12.18 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4125

Roujin wrote:

Okay, major trunk changes in window code outdated this :D
Going to rewrite it soon'ish... hope it gets more chances when you're done with the window stuff ;)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4152

Roujin wrote:

I have posted my newest approach in combination with a question in the forums here: http://www.tt-forums.net/viewtopic.php?f=33&t=35627&p=692343# p692343

It's a major rehaul, I think it is quite clean and understandable now, please do have a look at it and help me :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4155

Roujin wrote:

.diff updated to r13265...

Attachments

• new_dragdraw.diff (10.43 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4184

Roujin wrote:

Here's an update to trunk. Hope you haven't forgotten me...

Attachments

• new_dragdraw.diff (10.43 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4246

SmatZ wrote:

Hello,

thanks for patches. What do you think about idea to raise/lower to different height? It could be done by dragging or after timeout while satying at the same tile.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4360

Roujin wrote:

There is a problem with that.
If I raise one edge, the mouse cursor might move to another tile due to the changed surface. Now there's one pesky spot where, if multi-height raising were allowed, the mouse cursor would move back and forth between two edges, raising every time, until we have a little mountain. This happens so fast that it's not controllable by the user.

This also won't be prevented by the proposed timeout, because we're not staying at the same tile when that happens, but jump between two tiles.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001#comment4378

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/2001