Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station naming not following catchment areas. #1961

Closed
DorpsGek opened this issue Apr 28, 2008 · 5 comments
Closed

Station naming not following catchment areas. #1961

DorpsGek opened this issue Apr 28, 2008 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Roujin opened the ticket and wrote:

At the moment, the code to generate a name for a station that is being built scans an area of radius 3 around the northernmost tile of the station to be placed for stuff indicating how to name the station (e.g. trees, mines, ...).
It doesn't take into account the size of the station that is being built, nor the size of the catchment area (which can differ if the improved catchment radius patch option is used).

I've made a patch that changes the code to take the correct station bounds and catchment area size into account.
There are also some comments fixed and one variable renamed to something more understandable.

Please comment..

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1961
@DorpsGek
Copy link
Member Author

Roujin wrote:

Seems i cannot upload stuff at the moment. Please have a look at the patch here: http://www.tt-forums.net/download/file.php?id=90157


This comment was imported from FlySpray: https://bugs.openttd.org/task/1961#comment4014

@DorpsGek
Copy link
Member Author

Rubidium wrote:

So when you build a 64x64 station, so a 72x72 catchment area, 8 tiles with trees are enough to make it 'in the forest'? Would be really hard not to be in a forest then.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1961#comment4015

@DorpsGek
Copy link
Member Author

Roujin wrote:

Then let's check not for 8 tiles, but for a number dependant on the size of the station/catchment. That would be a percentage then.
Proposals?

The current code checks for 8 tiles with trees in an area of 7*7 tiles, that's about 1/6 = 15%. I think this should be raised to, like, 25%?

so it would check for something like
CountMapSquareAround(tile, width, height, rad, CMSATree) >= (width + 2 * rad) * (height + 2 * rad) / 4

Better like this? Or do you completely disagree with this? I mean, currently, it searches only around the upper square of the station, so if the station is a bit larger and next to a mine somewhere more to the south, it won't be named mine. That's why I called this entry "bug report" originally..


This comment was imported from FlySpray: https://bugs.openttd.org/task/1961#comment4016

@DorpsGek
Copy link
Member Author

Roujin wrote:

Actually I have a few more ideas about station naming.. maybe a list of the available standard names instead of the computer just picking (seemingly) a random one.
Maybe when clicking on rename station, additionally to the possibility to enter a custom name, display the list of standard names available for this station.
Maybe reimplement my previous patch (industry station names) properly.

But as patches with a lot of new stuff have low chance of acceptance i thought i'd start little and clean up some stuff that's currently messy.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1961#comment4017

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1961

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant