Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bridge over bridge foundation => graphical glitches in some cases #1935

Closed
DorpsGek opened this issue Apr 16, 2008 · 5 comments
Closed

bridge over bridge foundation => graphical glitches in some cases #1935

DorpsGek opened this issue Apr 16, 2008 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Zuu opened the ticket and wrote:

This glitch exist in last nightly 12717, 0.6.0 beta 2, and possible older versions.

Have a look on the attached image

Conditions:
* The upper bridge must be e-rails. (I have not checked maglev/monorail)
* The lower bridge must also be e-rails.
* The lower bridge must be "infront" of the upper bridge (if it starts under and then goes in the other direction no glitches happens)
* Some bridges are more prone to glitches.
- A tubular on the top gives easy to spot glitches. The cantilever bridges also gives easy to spot glitches.
- Grinder Steel (257km/h), Tubular steel and wodden bridge as lower bridge gives glitches

My theory is that it could have to do something with the bounding box of the sprite of the lower bridge collides in some way with the sprite used for the upper bridge, and therefor parts of the upper bridge is not drawn.

Attached save game using last nightly r12717 on a 64x64 map with no GRFs.

There exist another bug report about bridge glitches (task 1933) but my impression is that this is not a duplication of task 1933.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1935
@DorpsGek
Copy link
Member Author

Rubidium wrote:

This is rather a duplication of #119 I guess.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1935#comment3921

@DorpsGek
Copy link
Member Author

frosch wrote:

Ok, it was not the wire as I thought first. Though IMO the wire should be suppressed too.

Here the last pillar on each of the lower bridges causes a cyclic dependency with the backside of the lower bridge and the Z-separator-box of the higher bridge.

The attached patch breaks this circle by making the bounding-boxes of the pillars at bridge-ends smaller. But as I always: Fixing one glitch may cause others...

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1935#comment3924

@DorpsGek
Copy link
Member Author

Rubidium wrote:

The patch certainly reduces glitches, but this whole combination of bridges is way more glitchy when a train runs over it.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1935#comment3926

@DorpsGek
Copy link
Member Author

frosch wrote:

Ok, replace "pillar" with "train" in my obove post.

Consider the three sprites:
# 1: Waggon half on the lower bridge, half under the higher bridge.
# 2: Backside of lower bridge.
# 3: Floor of higher bridge.

Rubidium's savegame shows:
# 1 needs to be drawn in front of # 2,
# 2 needs to be drawn in front of # 3,
# 3 needs to be drawn in front of # 1.
These are requirements of the graphics, no matter how the BB are defined)

Without elrail catenary the spritesorter is lucky, to only sort # 3 behind # 1 which is less visible.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1935#comment3936

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Duplicate

This is also one of the few 'seems to be unfixable' glitches between graphics in OpenTTD that are described in #119. I've added a note about this bug in there so it won't be forgotten.
Having two bugreports for the same kind of issue isn't very useful.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1935

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek