Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique names not always enforced #1923

Closed
DorpsGek opened this issue Apr 13, 2008 · 4 comments
Closed

unique names not always enforced #1923

DorpsGek opened this issue Apr 13, 2008 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Yexo opened the ticket and wrote:

Currently using revision 12672, but the same can happen with 0.6.0

It's quite easily to let the game create non-unique names for groups/trains/stations etc. For example: create a group, it'll get the name "Group 0". Now rename it to "Group 1", after that create another group, it'll also be named "Group 1".

Other example (Assume the language is set to Dutch): create two stations near the center of a town, one of them will be called "TOWN_NAME" and the other "TOWN_NAME centraal". Rename the first to "TOWN_NAME Central" and then change language to English. The second station will be rename to "TOWN_NAME Central", again two stations with the same name. This second example can happen the same in multiplayer, if the players have different language options, some of them will be able to rename the station to "TOWN_NAME Central" (those with non-english languages) while the english players won't be able to change the name.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1923
@DorpsGek
Copy link
Member Author

SmatZ wrote:

It depends on laguage you are using. If you named the group "Skupina 1", then it would be duplicated name for me (but not for you).

Possible solution is to check custom names only, but it has to be decided.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1923#comment3873

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 6, 2008

SmatZ wrote:

Since r14334, there is another problem:
you rename something, then rename something to its old name, and then you reset the name -> two things with the same name

Like:
"Vehicle 1" -> "temp name"
"Vehicle 2" -> "Vehicle 1"
"temp name" ->(default)-> "Vehicle 1"

This way, you may have two towns with the same name (generate first, rename, generate second with same default name, reset the first)

(probably, untested)


This comment was imported from FlySpray: https://bugs.openttd.org/task/1923#comment4826

@DorpsGek
Copy link
Member Author

SmatZ wrote:

There are other hardly solvable situations:

language is changed by user, so default names are changed (-> collisions)
'Train 1' is renamed to 'Train 2', then 'Train 2' is built


This comment was imported from FlySpray: https://bugs.openttd.org/task/1923#comment5280

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Not a bug

since r14958, only custom names are checked for duplicates


This comment was imported from FlySpray: https://bugs.openttd.org/task/1923

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant