Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airplanes copy helipcopters goto heliport order #1890

Closed
DorpsGek opened this issue Mar 30, 2008 · 8 comments
Closed

airplanes copy helipcopters goto heliport order #1890

DorpsGek opened this issue Mar 30, 2008 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

athanasios opened the ticket and wrote:

When clicking to a helicopter that includes orders to any type of heliport to copy them as orders of an airplane all orders are copied including those of goto a heliport.

Instead, a warning should be issued that orders include a non reachable destination and maybe let the player decide how to proceed.

Since this is somewhat relevant: I suggest a similar message regarding small/large airports and small/big aircraft.

Reported version: 0.6.0-RC1
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1890
@DorpsGek
Copy link
Member Author

yorick wrote:

The attached patch fixes the problem as is done with trucks: just return CMD_ERROR.
Tested and working.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890#comment3965

@DorpsGek
Copy link
Member Author

yorick wrote:

New version (thanks Belugas!) with the check made a function to avoid code duplication.
Could also be used with only one parameter to check if all orders of a vehicle are valid in a way the aircraft can use the station.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890#comment3966

@DorpsGek
Copy link
Member Author

yorick wrote:

Code style compatible!

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890#comment3967

@DorpsGek
Copy link
Member Author

yorick wrote:

Examples should be right }|

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890#comment3968

@DorpsGek
Copy link
Member Author

yorick wrote:

Hmm...shared orders still exposes the bug, so it isn't finished yet. But one difficulty:
Should I just forbid shared orders cross-type, or should I forbid adding orders that aren't compatible for one vehicle to the shared order list?

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890#comment3973

@DorpsGek
Copy link
Member Author

yorick wrote:

New version, now with shared orders fix, and also applied for trucks.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890#comment3980

@DorpsGek
Copy link
Member Author

yorick wrote:

updated to r14036

- edit: fixed whitespace
-edit2: I seem unable to delete files, but fs1890_fix_yorick_2.diff is the correct one

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890#comment4581

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r14954.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1890

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek