Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flags + language flags in MP client list #1866

Closed
DorpsGek opened this issue Mar 19, 2008 · 6 comments
Closed

More flags + language flags in MP client list #1866

DorpsGek opened this issue Mar 19, 2008 · 6 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

yorick opened the ticket and wrote:

Hello, I've been working on a new patch last week, it's about adding language flags to the client list and adding more flags to the network protocol, because the last update was at r10017 and a few languages have been added meanwhile.
LordAzamath has drawn me some flags to use for my patch.

The first part of the patch - adding more flags - is attached in files, the second part will soon be attached to a comment (hopefully :p).

Usage of the files:
The first screenshot is a screenshot of the extra languages (Afrikaans in this case).
The second one is a screenshot of the final part, yet to be polished.
The third one is a diff that should be applied to /extra/ottd_grf/
The fourth one is a pcx file that should be overwriting /extra/ottd_src/split/flags.pcx and the last one is the diff that should be applied to trunk.
The NETLANG_* enum is even defined when ./configure --DISABLE-NETWORKING is done, because the languages are used at the isocode-netlang-grflang conversion which is done inside newgrf_text.cpp.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1866
@DorpsGek
Copy link
Member Author

yorick wrote:

New checksums

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1866#comment3757

@DorpsGek
Copy link
Member Author

yorick wrote:

Thank you for committing the first part, glx :)
I'll put the second part online soon.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1866#comment3761

@DorpsGek
Copy link
Member Author

yorick wrote:

This is the final part of this patch, with the flags a bit moved to the right because some strings didn't fit there.
I hope it gets into trunk soon :)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1866#comment3762

@DorpsGek
Copy link
Member Author

yorick wrote:

New version, changes:
- updated to r12435
- merged PACKET_CLIENT_SET_PASSWORD into PACKET_CLIENT_SET_INFO
- made PACKET_CLIENT_SET_INFO arguments and the actual data sent optional
- changed NETWORK_CHANGETYPE_* to work with bitwise things, so you can do multiple changes using 1 packet (support is there, but not used (yet))
Good luck!

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1866#comment3767

@DorpsGek
Copy link
Member Author

yorick wrote:

Updated to r12837.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1866#comment3957

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1866

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant