FS#1866 - More flags + language flags in MP client list

Attached to Project: OpenTTD
Opened by Yorick (yorick) - Wednesday, 19 March 2008, 14:24 GMT
Last edited by andythenorth (andythenorth) - Tuesday, 15 August 2017, 17:44 GMT
Type Work in progress
Category Interface
Status Closed
Assigned To andythenorth (andythenorth)
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


Hello, I've been working on a new patch last week, it's about adding language flags to the client list and adding more flags to the network protocol, because the last update was at r10017 and a few languages have been added meanwhile.
LordAzamath has drawn me some flags to use for my patch.

The first part of the patch - adding more flags - is attached in files, the second part will soon be attached to a comment (hopefully :p).

Usage of the files:
The first screenshot is a screenshot of the extra languages (Afrikaans in this case).
The second one is a screenshot of the final part, yet to be polished.
The third one is a diff that should be applied to /extra/ottd_grf/
The fourth one is a pcx file that should be overwriting /extra/ottd_src/split/flags.pcx and the last one is the diff that should be applied to trunk.
The NETLANG_* enum is even defined when ./configure --DISABLE-NETWORKING is done, because the languages are used at the isocode-netlang-grflang conversion which is done inside newgrf_text.cpp.
This task depends upon

Closed by  andythenorth (andythenorth)
Tuesday, 15 August 2017, 17:44 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).
Comment by Yorick (yorick) - Monday, 24 March 2008, 19:29 GMT
New checksums
Comment by Yorick (yorick) - Monday, 24 March 2008, 21:50 GMT
Thank you for committing the first part, glx :)
I'll put the second part online soon.
Comment by Yorick (yorick) - Tuesday, 25 March 2008, 15:48 GMT
This is the final part of this patch, with the flags a bit moved to the right because some strings didn't fit there.
I hope it gets into trunk soon :)
Comment by Yorick (yorick) - Wednesday, 26 March 2008, 20:15 GMT
New version, changes:
- updated to r12435
- made PACKET_CLIENT_SET_INFO arguments and the actual data sent optional
- changed NETWORK_CHANGETYPE_* to work with bitwise things, so you can do multiple changes using 1 packet (support is there, but not used (yet))
Good luck!
Comment by Yorick (yorick) - Tuesday, 22 April 2008, 15:48 GMT
Updated to r12837.