Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack support for callback 37 #1862

Closed
DorpsGek opened this issue Mar 17, 2008 · 10 comments
Closed

Stack support for callback 37 #1862

DorpsGek opened this issue Mar 17, 2008 · 10 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

Could you please provide stack support for callback 37 the similar way as for callback 3A? That would allow to display stockpile size in the stored cargo text line

Reported version: 0.6.0-beta5
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1862
@DorpsGek
Copy link
Member Author

Belugas wrote:

Work has already begun on it.
It will not be part of the 0.6 betas nor RCs to come, tough, as we try to avoid as much as possible breaking the actual release process :)
If ever you already have a working grf based on the last proposal by Dalestan, it might be usefull for us to test it with :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment3720

@DorpsGek
Copy link
Member Author

George wrote:

Unfortunately Dale wrote that there is a difference he sees for the last proposal, so there is no public proposal available. Give me a description and I'll make a grf for you.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment3721

@DorpsGek
Copy link
Member Author

frosch wrote:

Attached patch adds support for textstack to CB37 in fund gui, industry view and industry list.
Registers 0x100 to 0x105 are copied to the stack.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment6834

@DorpsGek
Copy link
Member Author

George wrote:

Could you provide win32 executable so I could test it?

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment6835

@DorpsGek
Copy link
Member Author

frosch wrote:

i hope compiling resulted in something useful

edit: save space

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment6836

@DorpsGek
Copy link
Member Author

George wrote:

Looks like it works.
I'll improve the code and upload test version later

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment6837

@DorpsGek
Copy link
Member Author

George wrote:

Tests 1, 2 passed

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment6838

@DorpsGek
Copy link
Member Author

George wrote:

test 3 -several values in stack will be done tomorrow

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment6839

@DorpsGek
Copy link
Member Author

George wrote:

Test 3 passed
I could not make it work wrong (at least on all the tests I did), so I'd suggest to accept the diff and put it to trunck

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862#comment6845

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r17802

This comment was imported from FlySpray: https://bugs.openttd.org/task/1862

@DorpsGek DorpsGek added NewIndustries flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek