peter1138 wrote:

You might like to include a patch.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3700

Garthy wrote:

Certainly. I would recommend that this patch only be used for once-off testing at this stage, it's not 100% ready. Full details about what is wrong with it in the original post.

The file supplied is the output of:

diff -rup orig/OTTD-source-nightly-r12366 work/OTTD-source-nightly-r12366 > railtypeupgrade.diff

If the patch is best supplied in another form, please let me know and I'll see what I can do.

Attachments

• railtypeupgrade.diff (13.73 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3702

athanasios wrote:

Thanks.
Does it preserve group train belongs to?

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3714

Garthy wrote:

Hi Arthur,

Whilst I didn't add explicit support for it, and haven't ever used groups, I tried it out and it actually does preserve them. Train cloning seems to preserve group, and since my code uses train cloning to create a new train, the group seems to be preserved.

So yes, purely by accident. ;)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3716

Garthy wrote:

Okay, plan B: Here's the same patch with the tracewrites and incomplete openttd patch support code removed. It should be suitable to apply against the source to give you support for train rail type upgrades.

If you're here from a web search, and are looking to upgrade your trains from one rail type to another (eg. monorail to maglev), and want this feature before it is officially in the code, feel free to download the patch and apply against your code. Just be aware of the caveats I mention in my original post!

Devs: Please feel free to drop me a line if you'd like me to work with you to get this patch into the codebase. :)

Attachments

• railtypeupgrade-mini.diff (17.06 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3727

Garthy wrote:

Same patch tidied up a bit...

Attachments

• railtypeupgrade-mini.diff (11.20 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3728

SmatZ wrote:

I am afraid this can cause different test and exec runs very easily (see DC_EXEC). What happens if you can convert only some trains you have in the depot? (because of money, because of no available engine replacement). I didn't read the code in very detail, but I was able to make it assert after a while (several times converting between different rail types)
Also have a look at http://wiki.openttd.org/index.php/Coding_style

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3756

Garthy wrote:

Hi Zdenek,

Thanks for checking out my code.

Bearing in mind that I am new to the OpenTTD codebase, I should point out that I'm not too strong on the function of DC_EXEC. The impression I got is that most operations are handled by a run without DC_EXEC first, and then a run with. I had thought that on a run without DC_EXEC with failure conditions (eg. not corresponding wagon) it will fail and not proceed on the DC_EXEC run? If I am incorrect- do you have a set of circumstances that cause it to fail, so I can make it fail here as well?

Any tips on changing money levels (up and down) to allow me to experiment with this as well? I should be able to figure it out, I'm just wondering if there is an easy way.

Re assert failures, may I ask which version you applied from, what caused it, and where the assert failed? The patch removes two assertions, because they no longer hold true (one, for example, is a check that the train lengths match- something that isn't always true post-patch). Perhaps something went wrong there?

Please feel free to send me details and/or savefiles directly if you like- my email address can be found in this image: http://www.entropicsoftware.com/images/emailb.jpg. If I can recreate the problem, I might be able to fix it.

Thanks for the link to the coding style document- I have been guessing the style for now, an official doc will help me clean it up.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3766

SmatZ wrote:

Hello,

this is the assert I get:
src/command.cpp:628: bool DoCommandP(TileIndex, uint32, uint32, void (*)(bool, TileIndex, uint32, uint32), uint32, bool): Assertion `res.GetCost() == res2.GetCost() && CmdFailed(res) == CmdFailed(res2)' failed.

I think I was converting two depots at once, but maybe it was caused by something different. Maybe one depot could be converted while the second couldn't (the was train partially outside the depot).

When you need money, use the cheat - Ctrl+Alt+C

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3837

Garthy wrote:

It is unlikely that I'll be able to find the error with just the assert line, given my limited understanding of the code thus far. I fear I'll need a fair bit more information- such as version, a savefile, how to reproduce- to have much of a chance of finding the problem.

"Cheats" to reduce money are probably more helpful in testing than ones that increase it, especially in the context of "What happens if you can convert only some trains ... because of money".

Anyway...

It's been a few weeks now since I sent in the original code and I'm still not sure of a path to get this code into the main codebase, or if it is even useful or wanted. Enormously frustrating. As such, I think it best if I leave things be and move on at this point.

I hope that the code I've sent in proves useful in some way, even if just as inspiration or similar. The depot-finding code and wagon suggestion code included might be useful in some way.

Had this or similar code made it in, I imagine the direction I would have moved in next would have been:

- Add the ability to specify rail-type upgrades to the "Manage Trains" dialog in some way. Then use the wagon suggestion code as a fallback for when the player has not specified something explicitly.

- Add another option after "Manage Trains" with a name such as "Complete Rail Upgrade" to perform a complete rail-type upgrade of the whole map to the latest available type. Block it with a "Are you sure?"-type dialog to prevent misclicks.

I hope these ideas also prove useful in some way.

Anyway, many thanks for making OpenTTD available. I've had a lot of fun playing this game- much more than the original TTD. Best of luck with development!

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859#comment3847

Rubidium closed the ticket.

Reason for closing: Out of date

This comment was imported from FlySpray: https://bugs.openttd.org/task/1859