Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent industry from closing when building stations nearby #1857

Closed
DorpsGek opened this issue Mar 16, 2008 · 2 comments
Closed

Prevent industry from closing when building stations nearby #1857

DorpsGek opened this issue Mar 16, 2008 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Alberth opened the ticket and wrote:

Suggested by ToiletDuck: http://www.tt-forums.net/viewtopic.php?f=32&t=36653&start=0&st=0&sk=t&sd=a

To prevent industries from closing while building a transport line to them, the patch checks whether a new station has been built less than MAX_MONTHS_RECENTLY_NEW_STATION months ago near the industry. If so, the closure is not performed.

Note that the station may be intended for a different purpose than the industry that was prevented from closing. In that case, prevention of closure was incorrect. However, this information is not available until the station gets used. In this case, the closure is only postponed. Some time later, the industry will again be considered for closure, and then there is no new station nearby to prevent closure.

One possible abuse of this patch is to indefinitely prevent an industry from closing by regularly building a new station. However, it costs the player money and goodwill of the town to do so. It is much more efficient to start servicing the industry instead.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1857
@DorpsGek
Copy link
Member Author

Alberth wrote:

Upped to new revision. Also divided the patch in 2 parts. First some doxygen updates of current situation (can safely be put into trunk), followed by the patch to prevent industry closure as described above.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1857#comment4393

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1857

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant