Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with callback 10 (wagon power and visual effects) ... #1855

Closed
DorpsGek opened this issue Mar 16, 2008 · 3 comments
Closed

Problem with callback 10 (wagon power and visual effects) ... #1855

DorpsGek opened this issue Mar 16, 2008 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

OzTransLtd opened the ticket and wrote:

Problem with callback 10 (wagon power and visual effects) ...

Cab Car data : property 19 (traction) = 0x08 [diesel]; 22 (visual effects) = 0x40 [no effects]

In TTDPatch, callback 10 is called in the depot and every time the train reverses (i.e. terminus stations, by player, end of line).

Depending, how train has been built; cab car leading or trailing and whether the cab car leads consist (visually) or not, there are either no visual effects or the ones of the trailing engine to be shown, which can be either steam or diesel smoke (depending what vehicle (in reality) is at the other end).

In OpenTTD, CB10 has the following effect :

a) cab car leads (visually) : CB10 returns 0x40 and no effects are shown and this is correct.
b) cab car trails (visually) : CB10 returns either 0x04 or 0x0A for steam but diesel smoke is shown, this is incorrect.

Note : veh property 19 is set to traction used most commonly, but visual effects are set via CB10 at all times. The reverse happens for the engine, but that works correctly.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1855
@DorpsGek
Copy link
Member Author

peter1138 wrote:

Range Effect type
00..0F Use the default effect type from property 19, but reposition it
10..1F Steam puffs
20..2F Diesel fumes
30..3F Electric sparks

So even according to the NFO spec, your 0x04 / 0x0A should indeed be using diesel, as prop 19 is set to diesel.
You should use 0x14 / 0x1A for it to use steam.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1855#comment3690

@DorpsGek
Copy link
Member Author

OzTransLtd wrote:

One should read those specs a bit more carefully; now using 0x00 .. 0x0F is a bug in TTDPatch. Thanks, it works; this one can be closed.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1855#comment3693

@DorpsGek
Copy link
Member Author

peter1138 closed the ticket.

Reason for closing: Not a bug

Closed as requested


This comment was imported from FlySpray: https://bugs.openttd.org/task/1855

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant