Noldo opened the ticket and wrote:

Why??
Wouldn't it be nice if all the pathfinders for specific vehicle type has a clean interface?

Added:
-abstract class ShipPf that is the interface common to all ship pathfinders.
-derived classes for each current ship pathfinder.
-files pathfinder_front.{h|cpp}

Moved:
-this and that from ship_cmd.cpp to pathfinder_front.cpp to make the original ChooseShipTrack look the way it looks.

Collateral Damage / Nice Bonus:
OPF/NPF code got removed from ship_cmd.cpp

Problems:
-Some of the static variables and functions that were needed in the pathfinder_front.cpp were also needed in non-related
contexts elsewhere in ship_cmd.cpp so I left those in ship_cmd.cpp too which is ugly code and data duplication and needs a solution.
-Also the Depot finding function is duplicated in ShipPf_Yapf and ShipPf_Opf, deriving one from the other would solve that,
but maybe there's some better solution.

Development ideas:
-The switch/case construct could propably be replaced with some kind of array-like thing that is indexed with the patch setting.

Attachments

• ship_pathfinder_facade_r12357.diff (13.70 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1843