Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with GRF varaction 2 station variable 41 #1832

Closed
DorpsGek opened this issue Mar 7, 2008 · 5 comments
Closed

Problem with GRF varaction 2 station variable 41 #1832

DorpsGek opened this issue Mar 7, 2008 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 7, 2008

mart3p opened the ticket and wrote:

Variable 41 is supposed to return platform info and relative position for individually built parts of a station. This does not seem to be working correctly in OpenTTD. The difference between the behaviour in TTDPatch and OpenTTD is shown in the screenshots, with 2 different station configurations.

This station is using bits 0 to 3 of the value returned by var.41 (position along platform from north) to determine when to build the taller building. It should be built on the most northerly tile. But when a platform is built in two parts, I would expect the northern tile of each part to be a taller building, as happens in TTDPatch.

A test GRF with a much simplified version of this station is attached that demonstrates the problem.

Attachments

Reported version: 0.6.0-beta5
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1832
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 7, 2008

peter1138 wrote:

By design...

Can be changed by removing lines 670-673 of newgrf_station.cpp


This comment was imported from FlySpray: https://bugs.openttd.org/task/1832#comment3608

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 7, 2008

mart3p wrote:

Yes, it works as I would have expected with those lines removed...

So, why are those lines needed? Var. 41 seems fairly useless if it has the same behaviour as var. 40.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1832#comment3609

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 7, 2008

peter1138 wrote:

There is a reason. I just can't remember it any more.

Possibly because the limit on station parts could get used up more rapidly...


This comment was imported from FlySpray: https://bugs.openttd.org/task/1832#comment3610

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 7, 2008

mart3p wrote:

Could it be changed, so that at least parts of the station with a different orientation, are allocated with a different station spec?


This comment was imported from FlySpray: https://bugs.openttd.org/task/1832#comment3611

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r14956.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1832

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) NewStations labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant