Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision not determined on XP x64 - MSVC #1831

Closed
DorpsGek opened this issue Mar 6, 2008 · 3 comments
Closed

Revision not determined on XP x64 - MSVC #1831

DorpsGek opened this issue Mar 6, 2008 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 6, 2008

Jafinto opened the ticket and wrote:

(Note: the following two paragraphs are an introduction) After a long time using nightlies, I wanted to test YAPP. So, after installing and configuring everything, I started to compile trunk. Being happy that succeeded (I had several compile errors a few years ago), I started the program. But when running OpenTTD, I got a warning about the used font and several sprites were missing (the red question mark).

It took me nearly two hours to figure out that it couldn't be the data files (as they worked with the nightlies), nor the Windows SDK (I reinstalled it). Compiling OpenTTD in a virtual machine running XP Home (x86) worked on the other hand: the question marks were gone. So, I started to recompile trunk on my host os (XP Pro x64), where I got the same problems as before.
I noticed one difference though: the x64 version didn't have a revision.

(real bug report starts here ;) determineversion.vbs, the file that checks the revision for Windows, doesn't work on Windows XP x64 (and supposedly on Vista x64) in combination with MSVC (i've tested only VC 9, but it should be the same with VC 8) and the x64 version of TortoiseSVN. The script tries to find Tortoise by looking in the registry for the Key "HKLMSOFTWARETortoiseSVNDirectory". The problem isn't the script itself, but the script in combination with MSVC.

On Windows x64, 32-bit programs aren't allowed to read and write in "HKLMSOFTWARE". Instead they perform there actions in "HKLMSOFTWAREWow6432Node". When running the determineversion.vbs from explorer, it gets executed by a 64-bit instance of the interpreter, and it executes normally. But, when you run the script via MSVC, which is the default, it gets executed by the 32-bit instance of the interpreter, because MSVC is 32-bit. Thus, it the TortoiseSVN entry in "HKLMSOFTWAREWow6432NodeTortoiseSVNDirectory". That key does not exist when the 64-bit version of TortoiseSVN is installed, I assume it does exist when the 32-bit version is installed.

What struck me the most, were the errors OpenTTD gives when the version is unknown ("norev000"). I don't know much about Visual Basic, so I don't know if there are functions to check for this. Perhaps this should be fixed, or else stated in the readme?

Anyway, I'm going to compile YAPP now.

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/1831
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 7, 2008

michi_cc wrote:

You can install the 32-bit version of TortoiseSVN in parallel to the 64-bit version. This might not be the most elegant solution, but it works.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1831#comment3614

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2008

peter1138 wrote:

From your description I would say this is a TortoiseSVN bug, not our scripts.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1831#comment3627

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Duplicate

Of #1847 - reason is the same


This comment was imported from FlySpray: https://bugs.openttd.org/task/1831

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) duplicate labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant