Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Industry prop 24 support #1822

Closed
DorpsGek opened this issue Mar 2, 2008 · 4 comments
Closed

Industry prop 24 support #1822

DorpsGek opened this issue Mar 2, 2008 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 2, 2008

George opened the ticket and wrote:

Please implement prop 24. I need it for ECS Agricultural vector beta 4. If it is already implemented, I'll provide a test GRF, because it does not work for me.

http://wiki.ttdpatch.net/tiki-index.php?page=Action0Industries
Default name for nearby station (24)
If non-zero, this text ID specifies an additional name option for stations built near this industry, which will be used before any of the standard TTD names. The text should contain a 80, which will be the name of the nearby town.
If the newly built station cannot use the specified text (because that name has been used for another station in the same town) the default TTD naming system will be used, but without the names "80 Oilfield" or "80 Mines".
Setting this to zero disables "80 Oilfield" and "80 Mines" without adding any additional station name options.

Reported version: 0.6.0-beta4
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1822
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 2, 2008

Belugas wrote:

The work to implement it has already been started.
It's not just an easy one to code, if it has to be done properly.
Thanks for pointing it out :)
The loader and the property itself is coded, the string manipulations are not done, nor the detection of already named stations, nor the disabling.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1822#comment3593

@DorpsGek
Copy link
Member Author

Yexo wrote:

Attached a patch with the missing code to support this property. I've tested it with station_names.grf (found http://www.tt-forums.net/viewtopic.php?f=26&t=40523)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1822#comment5022

@DorpsGek
Copy link
Member Author

Yexo wrote:

Small bugfix: take the town of the station as base instead of the town of the industry. (pointed out by Roujin)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1822#comment5034

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

In r14598.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1822

@DorpsGek DorpsGek added NewIndustries flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek