FS#1817 - wrong transparency options (Patch included)

Attached to Project: OpenTTD
Opened by Manuel Wolf (Roujin) - Friday, 29 February 2008, 12:34 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


ResetRestoreAllTransparency() in transparency.h also set/cleared bits of non-existant transparency options. This in combination with the transparency locks led to wrongly set transparency options when exiting and reentering the game.

Steps to reproduce:
- launch OpenTTD
- start new game
- set transparency locks on any option(s) (not all)
- toggle transparency (it should be ON now for all non-locked options)
- exit game to OS
- launch OpenTTD
- start new game
=> wrong transparency options set (also the locked ones)

This patch should fix the bug. Modified ResetRestoreAllTransparency() to not change any bits outside of the existing number of transparency options.
Also fixed one typo and added a comment in transparency_gui.cpp that was missed when the ninth transparency option was added.
This task depends upon

Closed by  Peter Nelson (peter1138)
Friday, 29 February 2008, 15:19 GMT
Reason for closing:  Fixed
Additional comments about closing:  r12320