Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electric Trains can leave Conventional Depot #178

Closed
DorpsGek opened this issue May 18, 2006 · 4 comments
Closed

Electric Trains can leave Conventional Depot #178

DorpsGek opened this issue May 18, 2006 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Eddi opened the ticket and wrote:

to reproduce:

- build electric depot
- build electric train
- convert depot to conventional
- start train

the train leaves the depot without checking that it is incompatible rail

i think you should be able to convert depots with incompatible trains inside, to be able to upgrade the network without loosing the orders
but those trains should not be able to leave the depot

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/178
@DorpsGek
Copy link
Member Author

Bjarni wrote:

well even if the depot can be converted with a train in it, then how about this:
- you build an electric engine
- you build a diesel engine
- you use the diesel engine to pull the electric engine to a conventional depot
- you sell the diesel and make a train out of the electric engine

The solution should be a failture to start from depots with 0 hp. Best solution would be to replace the green flag with an error icon of some sort and then show that one if the train tries to leave in addition to it to fail to leave


This comment was imported from FlySpray: https://bugs.openttd.org/task/178#comment288

@DorpsGek
Copy link
Member Author

glx wrote:

I implemented the flag replacement by a different icon (currently the lock from network games).
If the train has 0hp, the start/stop button in the train view window is disabled (same for the clic on flag in depot window).
The train power is updated when the depot is converted, and windows refreshed.

Btw, if you add a diesel engine, the 'lock' disappear and you can start the train :)

PS: I think a new gfx would be better. But I'm not good in drawing.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/178#comment289

@DorpsGek
Copy link
Member Author

glx wrote:

I fixed many bugs with trains running while depot conversion (ie if an electric train is partially in the depot, don't update his power until it is totally in depot, or it will stop and block everything). Same kind of changes for train reversing.

When an electric train is entering in a depot while the depot is converted, if his power becomes 0hp, the order is changed to stop the train.

I still need a better icon (I think the lock is not accurate).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/178#comment290

@DorpsGek
Copy link
Member Author

Bjarni closed the ticket.

Reason for closing: Fixed

fixed in revision 5853

we might need a new sprite for this, but so far "No Power" written in red will do


This comment was imported from FlySpray: https://bugs.openttd.org/task/178

@DorpsGek DorpsGek added Electrified rails flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant