Morloth opened the ticket and wrote:

I noticed a lot of functions (virtually all) should be static while they're not. For example, there is no reason why 'IndustryID GetMaxIndustryID ()' should be non-static. I haven't updated all functions (will do that in another patch), but I added a new function to AITile:

static IndustryID GetIndustry(TileIndex tile);

This function returns the industry (if any) is located at the given tile.

Also the following functions have been changed:
AITile.GetCargoAcceptance
AITile.GetCargoProduction

The prior functions only gave some numbers, GetCargoAcceptence said if the returning value is below 8, the cargo is not accepted; Higher is better. I changed these functions so they simply give true or false back as values. It'd be better of course if the function would return the actual production on a tile. But we'll leave that for the next version :).

Note: The last 2 changes might break existing AI implementations!

- Bram

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1779