Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert(bottom > 0) and assert (right > 0) #176

Closed
DorpsGek opened this issue May 14, 2006 · 3 comments
Closed

assert(bottom > 0) and assert (right > 0) #176

DorpsGek opened this issue May 14, 2006 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

ledow opened the ticket and wrote:

Occasionally, I still run into these assertions:

assert(bottom > 0)
assert(right > 0)

which are always fatal and crash the game. It appears to be related to slow computers (ones that pause while autosaving for instance) and the mouse. A lot of the time on these sorts of machines, the mouse will stop updating while the save occurs and then have one large update once it returns - this could be the cause. This is usually when this assertion occurs and it can happen while dragging a window, for instance. I've had it happen on a Linux PC with a PS/2 mouse and on a Windows laptop with a trackpad or USB mouse (both of a similar spec - 1GHz, 512Mb). No matter what I use, eventually I will get one of these assertions. Fortunately, reloading the last autosave is usually fine and it's rare enough that it's not too annoying.

I've had it happen in the latest SVN and in the latest stable for several months now. It's unpredictable and randomly reproducible and seems highly dependent on the computer that's being used (faster machines don't exhibit the problem, or at least not quite as badly).

The cause seems to be the calculations within the function GfxFillRect of gfx.c (this is the only place that such asserts occur and it has both of these asserts within close proximity).

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/176
@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 8, 2006

ledow wrote:

Bug still present as of SVN 5164

I am also testing a small patch that I made, which effectively bypasses the assert by setting a value it expects. Currently, just removing or ignoring the asserts does not work and the game just crashes later on, so they are definitely picking up on a problem somewhere.


This comment was imported from FlySpray: https://bugs.openttd.org/task/176#comment317

@DorpsGek
Copy link
Member Author

ledow wrote:

Possibly related to the bug described in: http://bugs.openttd.org/task/221 ?


This comment was imported from FlySpray: https://bugs.openttd.org/task/176#comment352

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 3, 2006

Tron closed the ticket.

Reason for closing: Fixed

This should be fixed by r6351


This comment was imported from FlySpray: https://bugs.openttd.org/task/176

@DorpsGek DorpsGek closed this as completed Sep 3, 2006
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant