FS#1747 - House override is broken

Attached to Project: OpenTTD
Opened by frosch (frosch) - Wednesday, 06 February 2008, 14:40 GMT
Type Bug
Category NewGRF
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


House override was broken in r11425.
E.g. when you take the alpine newgrf, snow on town houses is not working.

OverrideManagerBase::AddEntityID() calls GetID() to test if the entity has already been installed. But since r11425 GetID() does some more.
The attached patch seems to fix this, but to be honest I have no clue about the big picture, and if it is fixed the right way.

Note that OverrideManagerBase::AddEntityID() is also used by IndustryTiles. I don't know if they are broken too, or if this patch breaks them. PBI seems to work with both versions.
This task depends upon

Closed by  Loïc GUILLOUX (glx)
Friday, 08 February 2008, 16:57 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r12086.