frosch opened the ticket and wrote:

House override was broken in r11425.
E.g. when you take the alpine newgrf, snow on town houses is not working.

OverrideManagerBase::AddEntityID() calls GetID() to test if the entity has already been installed. But since r11425 GetID() does some more.
The attached patch seems to fix this, but to be honest I have no clue about the big picture, and if it is fixed the right way.

Note that OverrideManagerBase::AddEntityID() is also used by IndustryTiles. I don't know if they are broken too, or if this patch breaks them. PBI seems to work with both versions.

Attachments

• FixHouseOverrideBrokenIn11425.patch (1.92 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1747